BUG: fix a bug where setting zmin/zmax on a 2D plot with symlog norm would cause an undesired change in linthresh #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
neutrinoceros
force-pushed
the
hotfix_3887
branch
from
f9cefde
to
44e5362
Compare
…would cause an undesired change in linthresh
neutrinoceros
force-pushed
the
hotfix_3887
branch
from
88836f8
to
eab3b1c
Compare
chrishavlin
approved these changes
Apr 12, 2022
matthewturk
approved these changes
Apr 13, 2022
|
weird that this wasn't auto-backported in the first 10min (it's usually much quicker). Maybe the bot is under a big load right now, I'll try triggering it manually in a couple hours if nothing happens in the interval. |
|
@meeseeksdev backport to yt-4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Apr 13, 2022
…n a 2D plot with symlog norm would cause an undesired change in linthresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Goal: fix #3887 (without rebreaking #3858)
This patch already works for the intended example script, but I need to test it more before I can remove the draft status.
With this branch, the embedded script in #3887 produces the following image
which I think is a clear improvement over the current result on main
though defaults cannot be perfect in every case.