Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries #3863

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

neutrinoceros
Copy link
Member

PR Summary

fix #3862 by moving the responsibility of switching to origin="native" from AxisAlignedSlicePlot an AxisAlignedProjectionPlot to PlotWindow. Note that I'm not making any change to OffAxis...Plot classes, because they don't have support for non-cartesian geometries anyway, and they also don't expose the origin keyword argument.

matthewturk
matthewturk previously approved these changes Mar 28, 2022
@neutrinoceros
Copy link
Member Author

@matthewturk sorry for pushing again. This should now be ready.

@cphyc cphyc merged commit 4c3a310 into yt-project:main Mar 31, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 31, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout yt-4.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4c3a310a105e4d42bc300d44c3b63f1a5a95e3db
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am "Backport PR #3863: BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries"
  1. Push to a named branch:
git push YOURFORK yt-4.0.x:auto-backport-of-pr-3863-on-yt-4.0.x
  1. Create a PR against branch yt-4.0.x, I would have named this PR:

"Backport PR #3863 on branch yt-4.0.x (BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@neutrinoceros neutrinoceros deleted the hotfix_3862 branch March 31, 2022 07:56
neutrinoceros pushed a commit to neutrinoceros/yt that referenced this pull request Mar 31, 2022
BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries
(cherry picked from commit 4c3a310)
@neutrinoceros
Copy link
Member Author

manually backported as #3878

matthewturk added a commit that referenced this pull request Apr 13, 2022
Manual backport #3863 to yt-4.0.x (BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_pw ignores geometry specific rules ?
3 participants