-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries #3863
Conversation
220b24c
to
fc1e44b
Compare
…ctly in non-cartesian geometries
fc1e44b
to
f6dafe9
Compare
@matthewturk sorry for pushing again. This should now be ready. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries (cherry picked from commit 4c3a310)
manually backported as #3878 |
Manual backport #3863 to yt-4.0.x (BUG: fix a bug where PlotWindow origin parameter wasn't handled correctly in non-cartesian geometries)
PR Summary
fix #3862 by moving the responsibility of switching to
origin="native"
fromAxisAlignedSlicePlot
anAxisAlignedProjectionPlot
toPlotWindow
. Note that I'm not making any change toOffAxis...Plot
classes, because they don't have support for non-cartesian geometries anyway, and they also don't expose the origin keyword argument.