Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no ping before fetch mysql_insertid #16

Merged
merged 1 commit into from
May 18, 2017
Merged

no ping before fetch mysql_insertid #16

merged 1 commit into from
May 18, 2017

Conversation

tsucchi
Copy link
Collaborator

@tsucchi tsucchi commented May 18, 2017

https://github.com/CaptTofu/DBD-mysql/issues/59

mysql_insertid is cleared after ping() is called. so this fix avoid to call ping before last_insert_id(fetching mysql_insertid)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.131% when pulling 73e6b2b on tsucchi:no_ping_before_fetch_mysql_insertid into 710484e on ytnobody:master.

2 similar comments
@coveralls
Copy link

coveralls commented May 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.131% when pulling 73e6b2b on tsucchi:no_ping_before_fetch_mysql_insertid into 710484e on ytnobody:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.131% when pulling 73e6b2b on tsucchi:no_ping_before_fetch_mysql_insertid into 710484e on ytnobody:master.

@ytnobody ytnobody merged commit ccfa434 into ytnobody:master May 18, 2017
@tsucchi tsucchi deleted the no_ping_before_fetch_mysql_insertid branch May 18, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsucchi @coveralls @ytnobody