Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xCluster] Move retained_by_xcluster_ out of CatalogManager #21325

Closed
1 task done
Tracked by #19714
hari90 opened this issue Mar 5, 2024 · 0 comments
Closed
1 task done
Tracked by #19714

[xCluster] Move retained_by_xcluster_ out of CatalogManager #21325

hari90 opened this issue Mar 5, 2024 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented Mar 5, 2024 •
edited by jira bot
Loading

Jira Link: DB-10228

Description

Move to Xcluster Manager

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hari90 hari90 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Mar 5, 2024
@hari90 hari90 self-assigned this Mar 5, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Mar 5, 2024
@hari90 hari90 mentioned this issue Mar 5, 2024
Open
13 tasks
@hari90 hari90 removed the status/awaiting-triage Issue awaiting triage label Mar 6, 2024
hari90 added a commit that referenced this issue Mar 15, 2024
@hari90
[#21325] xCluster: Move retained_by_xcluster_ and xcluster_producer_t…
d25e0c2 
…ables_to_stream_map_ out of CatalogManager

Summary:
Move `CatalogManager::retained_by_xcluster_`  to `XClusterSourceManager::retained_hidden_tables_` and `CatalogManager::xcluster_producer_tables_to_stream_map_` to `XClusterSourceManager::tables_to_stream_map_`

Move logic to create a xCluster stream to `XClusterSourceManager`.

Rename functions in catalog manager so that they correctly reflect if they operate on CDCSDK, or xCluster or XRepl
Jira: DB-10228

Test Plan: Jenkins

Reviewers: jhe, xCluster, stiwary

Reviewed By: jhe

Subscribers: vkushwaha, asrivastava, ybase, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D32808
@hari90 hari90 closed this as completed Mar 15, 2024
hari90 added a commit that referenced this issue Mar 17, 2024
@hari90
[BACKPORT 2024.1][#21325] xCluster: Move retained_by_xcluster_ and xc…
fa4ebeb 
…luster_producer_tables_to_stream_map_ out of CatalogManager

Summary:
Original commit: d25e0c2 / D32808
Move `CatalogManager::retained_by_xcluster_`  to `XClusterSourceManager::retained_hidden_tables_` and `CatalogManager::xcluster_producer_tables_to_stream_map_` to `XClusterSourceManager::tables_to_stream_map_`

Move logic to create a xCluster stream to `XClusterSourceManager`.

Rename functions in catalog manager so that they correctly reflect if they operate on CDCSDK, or xCluster or XRepl
Jira: DB-10228

Test Plan: Jenkins

Reviewers: jhe, xCluster, stiwary, slingam

Reviewed By: slingam

Subscribers: bogdan, ybase, asrivastava, vkushwaha

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D33240
asrinivasanyb pushed a commit to asrinivasanyb/yugabyte-db that referenced this issue Mar 18, 2024
@hari90 @asrinivasanyb
[yugabyte#21325] xCluster: Move retained_by_xcluster_ and xcluster_pr…
abee218 
…oducer_tables_to_stream_map_ out of CatalogManager

Summary:
Move `CatalogManager::retained_by_xcluster_`  to `XClusterSourceManager::retained_hidden_tables_` and `CatalogManager::xcluster_producer_tables_to_stream_map_` to `XClusterSourceManager::tables_to_stream_map_`

Move logic to create a xCluster stream to `XClusterSourceManager`.

Rename functions in catalog manager so that they correctly reflect if they operate on CDCSDK, or xCluster or XRepl
Jira: DB-10228

Test Plan: Jenkins

Reviewers: jhe, xCluster, stiwary

Reviewed By: jhe

Subscribers: vkushwaha, asrivastava, ybase, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D32808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci