Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Try reviewdog #36

Closed
wants to merge 22 commits into from
Closed

test: Try reviewdog #36

wants to merge 22 commits into from

Conversation

yutotnh
Copy link
Owner

@yutotnh yutotnh commented Jan 16, 2024

No description provided.

@yutotnh yutotnh self-assigned this Jan 16, 2024
@yutotnh yutotnh added the enhancement New feature or request label Jan 16, 2024
src/extension.ts Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@@ -14,13 +14,13 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install Node.js
- name: Inistall Node.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
Unknown word (Inistall)

- uses: reviewdog/action-setup@v1
- run: yarn install
- name: Spell check
run: yarn cspell . | reviewdog -efm="%f:%l:%c - %m" -reporter=github-pr-check -level=error
run: yarn cspell . | reviewdog -efm="%f:%l:%c - %m" -reporter=github-pr-review -filter-mode=nofilter

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
Unknown word (nofilter)

src/extension.ts Outdated
@@ -45,7 +45,7 @@ export function cursorWordLeft() {
const editor = vscode.window.activeTextEditor;
if (!editor) {
logOutputChannel.warn(
"Could not get active text editor. Cannot move the cursor.",
"Could not get active text editor. Cannot move the cursor." ,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
"Could not get active text editor. Cannot move the cursor." ,
"Could not get active text editor. Cannot move the cursor.",

- uses: reviewdog/action-setup@v1
- run: yarn install
- name: Spell check
run: yarn cspell . | reviewdog -efm="%f:%l:%c - %m" -reporter=github-pr-check -level=error
run: yarn cspell . | reviewdog -efm="%f:%l:%c - %m" -reporter=github-pr-review -filter-mode=nofilter -fail-on-error=true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
Unknown word (nofilter)

@@ -0,0 +1,23 @@
on:
push:
branch: main

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
unexpected key "branch" for "push" section. expected one of "branches", "branches-ignore", "paths", "paths-ignore", "tags", "tags-ignore", "types", "workflows" [syntax-check]

push:
branch: main
tags:
- 'v\d+'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
character '' is invalid for branch and tag names. only special characters [, ?, +, *, \ ! can be escaped with . see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet [glob]

test:
strategy:
matrix:
os: [macos-latest, linux-latest]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
label "linux-latest" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]

os: [macos-latest, linux-latest]
runs-on: ${{ matrix.os }}
steps:
- run: echo "Checking commit '${{ github.event.head_commit.message }}'"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
"github.event.head_commit.message" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details [expression]

- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node_version: 16.x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
input "node_version" is not defined in action "actions/setup-node@v3". available inputs are "always-auth", "architecture", "cache", "cache-dependency-path", "check-latest", "node-version", "node-version-file", "registry-url", "scope", "token" [action]

- uses: actions/cache@v3
with:
path: ~/.npm
key: ${{ matrix.platform }}-node-${{ hashFiles('**/package-lock.json') }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
property "platform" is not defined in object type {os: string} [expression]

with:
path: ~/.npm
key: ${{ matrix.platform }}-node-${{ hashFiles('**/package-lock.json') }}
if: ${{ github.repository.permissions.admin == true }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
receiver of object dereference "permissions" must be type of object but got "string" [expression]

src/extension.ts Outdated
@@ -69,7 +69,7 @@ export function cursorWordLeft() {
}

line -= 1;
const lineText = editor.document.lineAt(line).text;
let lineText = editor.document.lineAt(line).text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'lineText' is never reassigned. Use 'const' instead.

Suggested change
let lineText = editor.document.lineAt(line).text;
const lineText = editor.document.lineAt(line).text;

Base automatically changed from 34-test-utilize-reviewdog to main January 16, 2024 15:34
@yutotnh
Copy link
Owner Author

yutotnh commented Jan 16, 2024

#34 がマージされたので遊び場である本Pull requestはCloseします

@yutotnh yutotnh closed this Jan 16, 2024
@yutotnh yutotnh reopened this Jan 17, 2024
@@ -21,7 +21,7 @@ jobs:
uses: reviewdog/action-eslint@v1
with:
eslint_flags: "src --ext ts"
fail_on_error: "true"
fail_on_error: "true"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
fail_on_error: "true"
fail_on_error: "true"

@@ -45,12 +45,12 @@ export function cursorWordLeft() {
const editor = vscode.window.activeTextEditor;
if (!editor) {
logOutputChannel.warn(
"Could not get active text editor. Cannot move the cursor.",
"Could not get active text editor. Cannot move the cursor."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
"Could not get active text editor. Cannot move the cursor."
"Could not get active text editor. Cannot move the cursor.",

);
return;
}

editor.selections = editor.selections.map((selection) => {
editor.selections = editor.selections.map((selection) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
editor.selections = editor.selections.map((selection) => {
editor.selections = editor.selections.map((selection) => {

@yutotnh
Copy link
Owner Author

yutotnh commented Jan 17, 2024

遊び終わったのでcloseします

@yutotnh yutotnh closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant