Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume slider to player toggles #148

Merged
merged 5 commits into from
Jun 1, 2019
Merged

Add volume slider to player toggles #148

merged 5 commits into from
Jun 1, 2019

Conversation

eralpsahin
Copy link
Contributor

@eralpsahin eralpsahin commented Jun 1, 2019

Implemented the feature request from #147

Additions

  • Adds a volume slider with similar style to main slider below Playback speed input under player-toggles menu in index.pug
  • Similar to playback speed previous settings persist between podcasts.
  • Finally, handles mprisPlayer similar to other handlers but, I am not sure if that is necessary. I don't understand why it is being checked.

TODO

  • Adds translation for en.json. Any help is appreciated for others. If it is okay, I can translate and add to other locales as well.
  • Also added TODO for adding keyboard shortcut handlers for volume change. I can add those as well.

Screen Shot 2019-05-31 at 23 04 16

If you want me to add anything, I am happy to.

@z-------------
Copy link
Owner

First of all, kudos and big thanks for looking through my poorly organized codebase and adding in this feature.

I've added in the keyboard shortcuts and a couple of other things.

The mpris stuff is for Linux users who want to be able to control CPod using their environment's interfaces. For example,

if (cbus.audio.mprisPlayer) {
  cbus.audio.mprisPlayer.volume = cbus.audio.element.volume;
}

simply tells mpris that we have changed the volume so that it will be reflected in the mpris interface.

@z------------- z------------- merged commit 4954b23 into z-------------:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants