Fix attachment request if content type is application/octet-stream #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sim0nx, Of course the issue on travis is not your fault. Could you pls remove all occurrences of |
|
Hi, Hmm it still fails with the same error, looks like travis does not take the latest commit into account...hmm |
|
I opened a new PR #50 to try to fix the travis run problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching binary attachments from RT with a returned content-type of application/octet-stream; trying to decode the body as utf-8 does not work and throws an exception.
The following is a simple fix to just ignore any decoding issues and fixes the issue.
Any chance you could merge this please?