Decouple imports to fix error in python3. #60
Conversation
In python3 both the try case and the except case fails: - io must be used instead of cStringIO - filterfalse must be used instead of ifilterfalse By decoupling these imports into separate try-excepts, this gets more robust and should work in more cases. Also make io the default as it should work for all python >=2.6.
|
@z4r , would you mind accepting this? The library is currently broken in Python 3.x. If you cannot find the time for it, please add more maintainers. I can become a co-maintainer if needed, I already maintain a couple of python libraries. |
|
Hi @danmichaelo, i sent you an invitation. |
|
Thanks, @z4r , I'll have a look at this later today. Could you also add me to PyPI, or do you prefer to keep control of that? |
|
pls @danmichaelo give me your ID on pypi |
|
Is there an ETA on merging this? As @danmichaelo noted, this library is currently broken as pulled via pip into a python3 environment. [a little time passes] Ah, I see the tests fail in spectacular ways. Fixing the import allows the system to at least load, but using rtkit appears to be the issue.. is that correct? If so, what work remains to port this over to python3? |
|
Hi @erichorne, I gave the role to @danmichaelo because ATM I've really no time to maintain this library. |
This changes fixes the import for cStringIO and ifilterfalse as intended by pull request z4r#60. In this old pull request the import for ifilterfalse is tried in the wrong direction for Python 2 and 3.
This changes fixes the import for cStringIO and ifilterfalse as intended by pull request z4r#60. In this old pull request the import for ifilterfalse is tried in the wrong direction for Python 2 and 3.
In python3 both the try case and the except case fails:
By decoupling these imports into separate try-excepts, this gets more
robust and should work in more cases. Also make io the default as it
should work for all python >=2.6.