Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render "Tambahkan Aktivitas" button conditionally #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zainfathoni
Copy link
Owner

@zainfathoni zainfathoni commented Aug 25, 2023

Closes #51

Description

Find a way to get the current pathname, and render the button conditionally.

Current Tasks

  • Get the current pathname
  • Render the button only when pathname ends with /contributions

Co-authored-by: Mohammad Farhan Fahrezy <farhanfahreezy@users.noreply.github.com>
Co-authored-by: Muhamad Dafian Zaki Akhdan <Rencist@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Aug 25, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
senarai ❌ Failed (Inspect) Aug 25, 2023 10:29am

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #52 (3b1388a) into main (32b11d0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   47.91%   47.89%   -0.02%     
==========================================
  Files          43       43              
  Lines        2471     2472       +1     
  Branches      133      133              
==========================================
  Hits         1184     1184              
- Misses       1259     1260       +1     
  Partials       28       28              
Files Changed Coverage Δ
app/components/top-navigation.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zainfathoni zainfathoni marked this pull request as ready for review August 25, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Unintended 404 for "Tambahkan Aktivitas" button to /new from home and about page
1 participant