Support 3.29.90 get neighbor workaround #81

matttbe · 2018-08-18T17:09:09Z

Hi,

This PR is based on the #80 with one more commit.

This is a workaround for GNOME 3.29.30 for this bug: https://gitlab.gnome.org/GNOME/mutter/issues/270
Without it, going left/right does nothing and down/up goes to the next/previous workspace. When you use to do that, it is disturbing :-)
Maybe other people also wants this workaround.

Even if it is a workaround, it should do exactly the same as before with older versions. It could then be merged as well and reverted later when the bug is fixed.

felipemarinho97 · 2018-08-30T22:25:44Z

workspace-grid@mathematical.coffee.gmail.com/extension.js

@@ -230,7 +232,7 @@ function indexToRowCol(index) {
 */
 function rowColToIndex(row, col) {
    // row-major. 0-based.
-    let idx = row * global.screen.workspace_grid.columns + col;
+    let idx = row * Utils.WS.getWS().workspace_grid.columns + col;


Why not create a constant for the Utils.WS.getWS() workspace manager?

This modification is inspired by what has been done in micheleg/dash-to-dock@8398d41
I suppose we cannot cache the workspace manager (even if I am not sure it can really change... maybe, I don't know :) )

workspace-grid@mathematical.coffee.gmail.com/metadata.json

workspace-grid@mathematical.coffee.gmail.com/extension.js

workspace-grid@mathematical.coffee.gmail.com/utils.js

zakkak · 2018-09-02T00:17:42Z

@matttbe thanks for your contributions, please have a look at my comments on how to potentially improve this PR

matttbe · 2018-09-02T10:59:59Z

@zakkak thank you for your review! Please tell me what you prefer:

simplify the code by breaking compatibility as done in official GNOME Shell extensions
check the version (if it is possible but I guess yes)
check the signature / available variables as done in other extensions like micheleg/dash-to-dock@8398d41

zakkak · 2018-09-02T18:50:39Z

In general I would go for simpler code and sacrifice compatibility, however since 3.28 is the latest version for ubuntu 18.04 which is an LTS release and people are starting to move to 3.30 on other distros I guess compatibility is something we need.

On the other hand if we are going to share source code for different versions it would be better to have if statements that make clear which part of the if/else is for which version, that's why I prompted for checking the version instead of some method signature that changed in the latest release.

matttbe · 2018-09-02T20:19:20Z

In general I would go for simpler code and sacrifice compatibility, however since 3.28 is the latest version for ubuntu 18.04 which is an LTS release and people are starting to move to 3.30 on other distros I guess compatibility is something we need.

You are right, I will keep the compatibility then!

On the other hand if we are going to share source code for different versions it would be better to have if statements that make clear which part of the if/else is for which version, that's why I prompted for checking the version instead of some method signature that changed in the latest release.

You are right, I will try to find something clearer.

Due to: https://gitlab.gnome.org/GNOME/gnome-shell/commit/47ea10b7 Inspired by micheleg/dash-to-dock@8398d41 - global.screen has been replaced by global.workspace_manager - Meta.ScreenCorner has been replaced by Meta.DisplayCorner - Main.wm._showWorkspaceSwitcher has less arguments (no more screen) Signed-off-by: Matthieu Baerts <matttbe@gmail.com>

global.get_overrides_settings() is no longer available. See: https://bugzilla.gnome.org/show_bug.cgi?id=786496 Signed-off-by: Matthieu Baerts <matttbe@gmail.com>

Bug report: https://gitlab.gnome.org/GNOME/mutter/issues/270 Signed-off-by: Matthieu Baerts <matttbe@gmail.com>

zakkak · 2018-09-04T08:35:04Z

It turns out the PR breaks the extension on 3.28

zakkak · 2018-09-04T08:36:24Z

@matttbe please reopen the PR with edits that don't break 3.28 support or just make a totally incompatible with 3.28 version and I will merge it in a new branch

matttbe · 2018-09-04T08:43:08Z

@zakkak thank you for having merge approved this.
I didn't verify if it was still supported in v3.28, I only checked by looking at the code.

Do you have more details about the error? I don't understand how Utils.WS.getWS(). Import are done in the two .js files I edited. I guess you have the new utils.js file in your extension directory.

I can try to check that on Gnome v3.28 but I am not sure I will have time before the week-end.

zakkak · 2018-09-04T08:53:07Z

I checked and the utils.js is indeed in the extension folder, not sure either why it breaks.

matttbe · 2018-09-04T08:58:29Z

@zakkak by chance, do you have a line number? I suspect more a typo due to an option I don't use. I am not sure why the same function would not be defined in 3.28 :)

zakkak · 2018-09-04T09:01:04Z

Nope, just saw the error through Alt+F2 lg, do you know how I could get a more verbose log, possibly with line numbers? I can't recall how to do it right now.

…

On 04/09/2018 11:58 πμ, Matthieu Baerts wrote: @zakkak <https://github.com/zakkak> by chance, do you have a line number? I suspect more a typo due to an option I don't use. I am not sure why the same function would not be defined in 3.28 :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#81 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXnA8V6tt5EUvyUMZnGIR6JSiHr0aKDks5uXkC1gaJpZM4WCpVa>.

matttbe · 2018-09-04T09:03:10Z

@zakkak I think you can use:

journalctl -f /usr/bin/gnome-shell -n 40

(note that the -f was not working for me recently, I didn't check why)

workspace-grid@mathematical.coffee.gmail.com/extension.js

zakkak · 2018-09-04T23:36:58Z

Sep 05 02:35:25 slimbee gnome-shell[2696]: JS WARNING: [/home/zakkak/.local/share/gnome-shell/extensions/workspace-grid@mathematical.coffee.gmail.com/utils.js 32]: reference to undefined property "workspace_manager"
Sep 05 02:35:25 slimbee gnome-shell[2696]: Extension "workspace-grid@mathematical.coffee.gmail.com" had error: TypeError: Utils.WS.getWS(...) is undefined

zakkak · 2018-09-05T00:06:51Z

The issue appears to be related to how you calculate the ShellVersionId.

Please try something like the following instead:

const ShellVersionId = (parseInt(ShellVersion[0]) << 8) + parseInt(ShellVersion[1]);

matttbe · 2018-09-05T07:39:23Z

Hi @zakkak,
Thank you, good catch :-)
Let me create a new PR with this fix!

felipemarinho97 reviewed Aug 30, 2018

View reviewed changes

workspace-grid@mathematical.coffee.gmail.com/metadata.json Show resolved Hide resolved

matttbe force-pushed the support-3.29.90-get_neighbor_workaround branch 2 times, most recently from 751f0f5 to fcd5e93 Compare September 1, 2018 19:38

matttbe mentioned this pull request Sep 1, 2018

Doesn't work with gnome-shell 3.29 #82

Closed

zakkak reviewed Sep 2, 2018

View reviewed changes

workspace-grid@mathematical.coffee.gmail.com/extension.js Outdated Show resolved Hide resolved

workspace-grid@mathematical.coffee.gmail.com/extension.js Outdated Show resolved Hide resolved

workspace-grid@mathematical.coffee.gmail.com/utils.js Outdated Show resolved Hide resolved

matttbe added 3 commits September 2, 2018 22:58

Gnome 3.30 support: Override schemas are gone

b073212

global.get_overrides_settings() is no longer available. See: https://bugzilla.gnome.org/show_bug.cgi?id=786496 Signed-off-by: Matthieu Baerts <matttbe@gmail.com>

GNOME 3.29.90: workaround for WS.get_neighbor(dir)

ef23483

Bug report: https://gitlab.gnome.org/GNOME/mutter/issues/270 Signed-off-by: Matthieu Baerts <matttbe@gmail.com>

matttbe force-pushed the support-3.29.90-get_neighbor_workaround branch from fcd5e93 to ef23483 Compare September 2, 2018 21:02

zakkak approved these changes Sep 4, 2018

View reviewed changes

zakkak merged commit 8cd1d2b into zakkak:3.28 Sep 4, 2018

zakkak mentioned this pull request Sep 4, 2018

Revert "Support 3.29.90 get neighbor workaround" #84

Merged

matttbe mentioned this pull request Sep 4, 2018

Gnome 3.30 support: MetaScreen has been removed #80

Closed

felipemarinho97 reviewed Sep 4, 2018

View reviewed changes

workspace-grid@mathematical.coffee.gmail.com/extension.js Show resolved Hide resolved

matttbe deleted the support-3.29.90-get_neighbor_workaround branch September 5, 2018 07:39

matttbe mentioned this pull request Sep 5, 2018

Support 3.29.90 get neighbor workaround #85

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support 3.29.90 get neighbor workaround #81

Support 3.29.90 get neighbor workaround #81

matttbe commented Aug 18, 2018

felipemarinho97 Aug 30, 2018

matttbe Aug 31, 2018

zakkak commented Sep 2, 2018

matttbe commented Sep 2, 2018

zakkak commented Sep 2, 2018

matttbe commented Sep 2, 2018

zakkak commented Sep 4, 2018

zakkak commented Sep 4, 2018

matttbe commented Sep 4, 2018

zakkak commented Sep 4, 2018

matttbe commented Sep 4, 2018

zakkak commented Sep 4, 2018 via email

matttbe commented Sep 4, 2018

zakkak commented Sep 4, 2018

zakkak commented Sep 5, 2018

matttbe commented Sep 5, 2018

Support 3.29.90 get neighbor workaround #81

Support 3.29.90 get neighbor workaround #81

Conversation

matttbe commented Aug 18, 2018

felipemarinho97 Aug 30, 2018

Choose a reason for hiding this comment

matttbe Aug 31, 2018

Choose a reason for hiding this comment

zakkak commented Sep 2, 2018

matttbe commented Sep 2, 2018

zakkak commented Sep 2, 2018

matttbe commented Sep 2, 2018

zakkak commented Sep 4, 2018

zakkak commented Sep 4, 2018

matttbe commented Sep 4, 2018

zakkak commented Sep 4, 2018

matttbe commented Sep 4, 2018

zakkak commented Sep 4, 2018 via email

matttbe commented Sep 4, 2018

zakkak commented Sep 4, 2018

zakkak commented Sep 5, 2018

matttbe commented Sep 5, 2018