Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UI components #303

Closed
prayerslayer opened this issue Sep 22, 2015 · 2 comments
Closed

Refactor UI components #303

prayerslayer opened this issue Sep 22, 2015 · 2 comments
Assignees

Comments

@prayerslayer
Copy link
Contributor

  • Data is passed via props instead of fetched from the stores via Flux instance
  • Actions are also passed via props
@prayerslayer prayerslayer added this to the Switch to Redux milestone Sep 22, 2015
@prayerslayer
Copy link
Contributor Author

See how we can utilize jscodeshift for this, because it's very mechanic:

  • Check if constructor (or any method) accesses props.flux or this.props.flux
  • If so, create properties for each of flux.getStore and flux.getAction
  • Rewrite the flux accesses to use those properties
  • If we use store.getSomething(args) rewrite it to Getter.getSomething(store, ...args) and add import * as Getter from ...

Dispatching actions correctly might still be a manual task.

prayerslayer added a commit that referenced this issue Oct 16, 2015
@prayerslayer prayerslayer self-assigned this Oct 16, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
prayerslayer added a commit that referenced this issue Oct 20, 2015
@prayerslayer
Copy link
Contributor Author

Fixed with #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant