skip creation later to improve visibility of errors #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
avaczi,
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
Jan-M
reviewed
Jun 16, 2020
Jan-M
reviewed
Jun 16, 2020
pkg/util/k8sutil/k8sutil.go
Outdated
| } | ||
|
|
||
| // SetStatus of Postgres cluster | ||
| // TODO: eventually switch to updateStatus() for kubernetes 1.11 and above |
There was a problem hiding this comment.
traveled with the code. I'll remove it. UpdateStatus requires a Postgresql struct with updated status. Seems easier as of now to just patch the CRD.
There was a problem hiding this comment.
I wonder if SetStatus should be called differently now that it lives inside k8sutil. Maybe SetPgStatus or SetCRDStatus
added 3 commits
June 17, 2020 12:53
FxKu
force-pushed
the
teamname-vs-clustername
branch
from
873ffd8 to
09c7e7a
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the cluster name does not start with the
teamIdwe are currently skipping the add event, which makes it hard to track the error from the UI. It is emitted neither to worker logs nor to K8s events. ThePostgresClusterStatus, although set during marshaling, remains empty.The PR does not skip the addEvent but will process it until the cluster would get created. This allows to show the error in logs accessible from UI and to record a K8s event with a working
ObjectReference.