Skip to content

delete secrets the right way #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2020
Merged

delete secrets the right way #1054

merged 3 commits into from
Jul 10, 2020

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Jul 9, 2020

as #974 did not do it

Jan-M
Jan-M reviewed Jul 9, 2020
View reviewed changes
@FxKu
Copy link
Member Author

FxKu commented Jul 9, 2020

👍

@FxKu FxKu added this to the 1.6 milestone Jul 10, 2020
@Jan-M
Copy link
Member

Jan-M commented Jul 10, 2020

👍

@FxKu FxKu merged commit 3759634 into master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jan-M Jan-M Jan-M left review comments

@avaczi avaczi Awaiting requested review from avaczi

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@erthalion erthalion Awaiting requested review from erthalion

@RafiaSabih RafiaSabih Awaiting requested review from RafiaSabih

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

2 participants

@FxKu @Jan-M