-
Notifications
You must be signed in to change notification settings - Fork 1k
Set user and group in security context #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1302,6 +1302,8 @@ func TestTLS(t *testing.T) { | |
var err error | ||
var spec acidv1.PostgresSpec | ||
var cluster *Cluster | ||
var spiloRunAsUser = int64(101) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above, while for users with the spec.fsGroup set this may be or have been the default for everyone not using fsGroup spec this seems to change the default from former root(0) to 101 uid. |
||
var spiloRunAsGroup = int64(103) | ||
var spiloFSGroup = int64(103) | ||
var additionalVolumes = spec.AdditionalVolumes | ||
|
||
|
@@ -1329,7 +1331,9 @@ func TestTLS(t *testing.T) { | |
ReplicationUsername: replicationUserName, | ||
}, | ||
Resources: config.Resources{ | ||
SpiloFSGroup: &spiloFSGroup, | ||
SpiloRunAsUser: &spiloRunAsUser, | ||
SpiloRunAsGroup: &spiloRunAsGroup, | ||
SpiloFSGroup: &spiloFSGroup, | ||
}, | ||
}, | ||
}, k8sutil.KubernetesClient{}, acidv1.Postgresql{}, logger, eventRecorder) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is here, this seems to set runAsUser and runAsGroup to the new 101/103 combination by default.
I will have to understand what this was/is before.