allow using both infrastructure_roles_options #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
avaczi,
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
erthalion
reviewed
Aug 10, 2020
erthalion
reviewed
Aug 10, 2020
erthalion
reviewed
Aug 10, 2020
erthalion
reviewed
Aug 10, 2020
erthalion
reviewed
Aug 10, 2020
| } | ||
| } else { | ||
|
|
||
| if roleDef.SecretName != emptyName && |
There was a problem hiding this comment.
It's probably better to have "validate" method.
erthalion
reviewed
Aug 10, 2020
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master only allows to set one of the two infrastructure roles options. If
infrastructure_roles_secretsis set,infrastructure_roles_secret_nameis ignored. However, as the new option doesn't allow "templating", so configmap users might still want to use old option but also being able to reference another secret with the new flexibility of choosing the keys.This PR also fixes a small "bug": When using the new configmap option one had to specify a
rolekey. But it could be that this info isn't available. CRD validation also doesn't enforce it.