-
Notifications
You must be signed in to change notification settings - Fork 1k
Introduce PGVERSION #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Introduce PGVERSION #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So this PR will also remove bin dir from spilo configuration? |
yes, it will. |
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spilo doc:
Using
PGVERSION
is now preferred to settingpostgresql.bin_dir
inSPILO_CONFIGURATION
This changes works just fine with any recent Spilo. Anyway as a precaution, we provide the toggle
pgversion_env_var
When it is "true", the environment contains only
PGVERSION
Otherwise
SPILO_CONFIGURATION
contains thepostgresql.bin_dir
subsection andPGVERSION
is unset. The latter behavior is not strictly necessary because in Spilo thebin_dir
takes precedence overPGVERSION
when both are set. I deliberately made this case more explicit on the operator side and decided not to setPGVERSION
whenbin_dir
is provided.Flipping
pgversion_env_var
costs a rolling upgrade because pod environment changes.per request from @CyberDem0n
See Spilo PR 222 for details.
blocked by #1160
closes #554