Add ability to upload logical backup to gcs #1173
Conversation
sagor999
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
I'm fine with these changes. Just wonder if the AWS default should be called |
|
👍 |
| S3AccessKeyID string `json:"logical_backup_s3_access_key_id,omitempty"` | ||
| S3SecretAccessKey string `json:"logical_backup_s3_secret_access_key,omitempty"` | ||
| S3SSE string `json:"logical_backup_s3_sse,omitempty"` | ||
| GoogleApplicationCredentials string `json:"logical_backup_google_application_credentials,omitempty"` |
There was a problem hiding this comment.
Should this be ..Path or ...File ?
There was a problem hiding this comment.
@Jan-M Hm. Technically it should be Path, since it refers to a path where google credentials are.
But, in AWSGCPConfiguration it is also simply gcp_credentials:
So if we were to update it here, we should probably update it there too? But that will be a breaking change then.
What do you think?
|
Even if this is not directly related, what about using a tool like rclone to export the backups ? This would make it possible to support S3 / GCS / Openstack Swift / ... transparently by just injecting the required env vars ? |
|
👍 |
|
@cambierr sure in theory we / I do consider it desireable that we have job/pod specs that others can leverage by providing customer docker images. |
This is based on:
#873
Resolved conflicts that original PR had.
@FxKu Would appreciate if you will have time to take a look at this one and hopefully approve it for merging.