Improve gcs docs #1179
Closed
Improve gcs docs #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to latest
sagor999
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
|
Thanks for the PR! One question, if it relies on #1176, why not move this change set into it? |
|
@erthalion I prefer not to bundle several changes together into one PR. But if you prefer, I can easily do that. Let me know. |
|
It's not a big deal I guess, but just in case I would ask you to pack the relevant changes together. It could be a separate commit to isolate stuff, but otherwise there is a chance to miss something. Does it sound good for you? |
|
@erthalion not a problem! I merged changes into #1176 and closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation on how to make cloning work when using GCS.
It relies on this PR to be approved first:
#1176