check resize mode on update events #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
CyberDem0n,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
Jan-M
reviewed
Nov 4, 2020
Jan-M
reviewed
Nov 4, 2020
FxKu
force-pushed
the
storage-resize-fixes
branch
from
898f065 to
b4ba102
Compare
RafiaSabih
reviewed
Nov 10, 2020
|
the test failure you see in this PR is addressed in #1202 |
sdudoladov
reviewed
Nov 11, 2020
|
👍 |
1 similar comment
|
👍 |
PetterSa
pushed a commit
to PetterSa/postgres-operator
that referenced
this pull request
Nov 19, 2020
* check resize mode on update events * add unit test for PVC resizing * set resize mode to pvc in charts and manifests * add test for quantityToGigabyte * just one debug line for syncing volumes * extend test and update log msg
PetterSa
added a commit
to PetterSa/postgres-operator
that referenced
this pull request
Nov 19, 2020
This reverts commit 2f542f0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risizing volumes by updating the PVC storage field has been introduced with #958. However the UPDATE event wasn't covered. Using
pvcmode requires more privileges than what we currently list in the operator cluster role. In the helm chart we can arrange the RBAC nicely by checking thestorage_resize_modesetting.This PR also changes the
storage_resize_modein example manifests and charts topvc. The internal default however remainsebs.