fix pooler sync with empty cluster name #1448
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
FxKu
force-pushed
the
pooler-sync-clustername
branch
from
4a7b991 to
b717ce5
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pooler deployment is updated on each sync:
The message is a bit confusing because it's the secrets which are compared. The current code uses
deployment.ClusterNamewhich is (or can be?) empty, hence producing a reason to update the deployment on every sync. The solution suggested in this PR is to use theNamefield of the cluster. Thus, makingneedSyncConnectionPoolerDefaultsa cluster method.