replace statefulset on annotation diff #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
CyberDem0n,
Jan-M,
RafiaSabih,
erthalion and
sdudoladov
as code owners
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1447
with
v1.6.2we moved the rolling update flag from statefulset to pods. Thus, after bumping the operator version during the next sync there will be a difference between the current and generated statefulset. If this is the only difference the statefulset is patched. But in K8s one cannot remove things withPatch. It requires anUpdateto do so. To avoid extending the cluster rbac, we can choose to replace the statefulset if annotations are different.In fact, our code does not even patch the statefulset if annotations for the new statefulset are empty.
The annotation update in Sync.go can go. There would be no difference at this point. I would even argue that line has been obsolete before. Actually we could also remove
updateStatefulSetAnnotationsfunction if we choose to replace the statefulset.