Support affinity and toleration in connection pooler deployments #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cucxabong
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
erthalion and
sdudoladov
as code owners
cucxabong
force-pushed
the
fix-1441
branch
2 times, most recently
from
d68f49a to
7600a34
Compare
FxKu
reviewed
Apr 23, 2021
|
This is missing the part for tolerations for node affinity as well. To allow to run it on dedicated node-group/pool. |
|
I added tolerations support here: |
|
Thank you @frankconrad , I incorporated your changes into this PR |
FxKu
changed the title
|
👍 |
1 similar comment
|
👍 |
|
Thanks @cucxabong and @frankconrad for your joint effort on this nice little enhancement. |
|
Now, on our cluster with 3 pooler instances and 3 K8s nodes, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1441