fix searching for users with namespace in name #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and simplify e2e test for cross namespace secrets.
Removed codelines have become obsolete, because the username will always contain the namespace at this point. At some stage of #1490 we've extracted the user from the full namespace-qualified name, hence making it necessary to add the namespace here. But, as of now, it would result in an error, because the namespace would be appended again (after the username, which seems strange, too). The name of the corresponding e2e test is changed, too, to be executed sooner and not at the end (which led to overseeing this bug).