fix(ui): update ingress api versions in helm chart for newer k8s vers… #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusheinemann
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
erthalion and
sdudoladov
as code owners
|
Thanks. Can you also change it in the example manifest for UI here? Just use the newest api version. No need for backwards compatibility here. |
|
done 😊 |
|
👍 |
1 similar comment
|
👍 |
|
Thanks @markus-codes for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1574
I have added an additional condition which applies the newer
networking.k8s.io/v1ingress configuration if the cluster version is greater than1.19.0.Maybe it should be considered to check which configuration is used based on
Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress"instead of comparing the cluster version. I used the second approach, because it was already implemented like this.