Fix empty resources spec field failing schema validation

[jgillich]

In Go, when a struct field is not set, it becomes a struct with
default values for all fields. These default values are included
during serialization. This causes issues with schema validation
where optional fields cannot be omitted because default values
are considered invalid.

This patch addresses this issue for Resources fields on several
types by using a pointer value.

[FxKu]

LGTM @jgillich
Maybe we can use this PR to go one step further and remove the required flag from resources in the CRD schema validation.
Here, here and here. Plus, remove for connection pooler as well. You or me can also do it in a separate PR.

[FxKu]

Speaking of the pooler. Can you do the same change on the pooler struct too @jgillich?

[jgillich]

Maybe we can use this PR to go one step further and remove the required flag from resources in the CRD schema validation.
Here, here and here. Plus, remove for connection pooler as well. You or me can also do it in a separate PR.

If this is something we want to do then we'll also have to turn all fields on Resources and ResourceDescription into pointer values or they won't be optional when constructed in Go code. I don't know the code base very well and it's easy to miss a nil check in some code paths so I don't know if I'm comfortable doing this. Unless you can ensure me the struct is always passed to generateResourceRequirements before being accessed. 😅

Speaking of the pooler. Can you do the same change on the pooler struct too @jgillich?

I believe already did - but I accidentally removed the composition, that has been fixed.

[FxKu]

Thanks @jgillich for the update. Yeah, lets lift the requirement another time.

[jopadi]

👍

[FxKu]

👍

[FxKu]

Thanks @jgillich for your contribution. Sorry it took so long to get it merged.