Helm chart generates incomplete ConfigMap #1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalbani
requested review from
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
Comparison between before and after the change when running:
|
|
👍 |
|
👍 |
This was referenced Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @StepanKuksenko in #1224 (comment), some properties are missing in the ConfigMap generated by the Helm chart.
This is due to the strict check on
if or (kindIs "string" $value) (kindIs "int" $value), whereas the list of variable types encountered by the function isstring,map,slice,boolandfloat64(see that the last 2 are missing inflattenValuesForConfigMap.My proposal is to actually use a
elsefallback, instead of explicitly looking for certain types.(The alternative would be to expand/modify the list of type if the first
ifto includeboolandfloat64.Question: how can we prevent this kind of problem from happening again the future? Is there an integration that could be expanded?