improve Patroni config sync #1635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current way of syncing and comparing Patroni config has a few issues:
synchronous_mode
andsynchronous_mode_strict
are not set in Spilo and create a diff with desired state even when not set, because the default isfalse
map[string]map[string]string
vs.map[string]interface{}
). Moreover, the slot settings should not be compared as a whole. It should only be checked if specified slots exist and if they differ.