Skip to content

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Oct 6, 2021

the current way of syncing and comparing Patroni config has a few issues:

  1. returned Patroni config can be empty but not nil, e.g. during restore which can crash the operator
  2. by default synchronous_mode and synchronous_mode_strict are not set in Spilo and create a diff with desired state even when not set, because the default is false
  3. slot comparison does not work even when they are semantically the same because go types are different (map[string]map[string]string vs. map[string]interface{}). Moreover, the slot settings should not be compared as a whole. It should only be checked if specified slots exist and if they differ.

@FxKu FxKu added this to the 1.7.1 milestone Oct 6, 2021
@Jan-M
Copy link
Member

Jan-M commented Oct 13, 2021

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Oct 13, 2021

👍

@FxKu FxKu merged commit 2a33bf3 into master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants