Skip to content

Conversation

preved911
Copy link
Contributor

Hello. Tolerations subfileds aren't required in all cases. I think that required subfields list should be removed from crd.

@FxKu
Copy link
Member

FxKu commented Feb 28, 2022

There is a third place you would have to remove it:

Required: []string{"key", "operator", "effect"},

Signed-off-by: Ildar Valiullin <preved.911@gmail.com>
@preved911 preved911 force-pushed the fix/postgresqls_tolerations_requirements branch from 70e279c to 8bced06 Compare February 28, 2022 12:25
@preved911
Copy link
Contributor Author

There is a third place you would have to remove it

thanks, removed

@FxKu FxKu added this to the 1.8 milestone Mar 21, 2022
@FxKu
Copy link
Member

FxKu commented Mar 21, 2022

👍

1 similar comment
@jopadi
Copy link
Member

jopadi commented Mar 21, 2022

👍

@FxKu FxKu merged commit 38db48c into zalando:master Mar 21, 2022
@FxKu
Copy link
Member

FxKu commented Mar 21, 2022

Thanks @preved911 for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants