LoadBalancer toggles for master and replica pooler pods #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Shatunov <me@prok.pw>
Signed-off-by: Sergey Shatunov <me@prok.pw>
sdudoladov
reviewed
Mar 2, 2022
|
|
||
| c.setProcessName("updating %v service", role) | ||
|
|
||
| if c.Services[role] == nil { |
There was a problem hiding this comment.
I had to remove all the c.Service[role] mentions in this function, hence the new oldService argument. If you look at the place where updateService is called c.Services[role] / c.ConnectionPooler[role].Service = svc is set just before. So this check is not needed - actually it was never really needed 😃 .
| } | ||
|
|
||
| func (c *Cluster) servicePort(role PostgresRole) string { | ||
| func (c *Cluster) servicePort(role PostgresRole) int32 { |
There was a problem hiding this comment.
that is better renamed generateServicePort - otherwise the logic of returning 5432 when a service does not exist is vauge
There was a problem hiding this comment.
Yes something like getServicePort would be better. But, now it's also in line with the other functions like serviceName, serviceAddress. I think, I would keep the name.
pkg/cluster/k8sres.go
Outdated
| c.logger.Warningf("No service for role %s", role) | ||
| return "" | ||
| c.logger.Warningf("No service for role %s - defaulting to port 5432", role) | ||
| return 5432 |
|
👍 |
1 similar comment
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #943.
Closes #943
Fixes #1774
Adding LB support for pooler pods. Required implementing update logic for pooler services.