Skip to content

refactor GenerateResourceRequirements and provide unit tests #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2022
Merged

refactor GenerateResourceRequirements and provide unit tests #1822

merged 3 commits into from
Mar 24, 2022

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Mar 23, 2022 •
edited
Loading

This PR does the following:

  • fixing a bug introduced by fix unit test and improve stability in e2e test #1819
  • lift the requirement for specifying full resources section
  • provide unit test for GenerateResourceRequirements
  • set request to limits inside GenerateResourceRequirements with an extra function
  • for enforceMinResourceLimits
    • move it to k8sres.go next to other resource functions
    • call it only from GenerateResourceRequirements
    • takes up v1.ResourceRequirements instead of PostgresSpec

@FxKu FxKu added this to the 1.8 milestone Mar 23, 2022
sdudoladov
sdudoladov reviewed Mar 23, 2022
View reviewed changes
@FxKu
Copy link
Member Author

FxKu commented Mar 24, 2022

👍

1 similar comment
@jopadi
Copy link
Member

jopadi commented Mar 24, 2022

👍

@FxKu FxKu merged commit 36df1bc into master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdudoladov sdudoladov sdudoladov left review comments

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

Assignees

No one assigned

Labels

bug zalando

Projects

None yet

Milestone

1.8

Development

Successfully merging this pull request may close these issues.

3 participants

@FxKu @jopadi @sdudoladov