-
Notifications
You must be signed in to change notification settings - Fork 1k
Standby cluster rebase #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add the example manifest for the standby cluster ?
docs/reference/cluster_manifest.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add the example manifest for the standby cluster ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added section to a manifests/complete-postgres-manifest.yaml file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it also makes sense to mention the required fields to make it work and add a link to the Patroni docs
@erthalion can you please have a look ? |
@redbaron do you want to continue development of this PR? Could you then address the commentaries, and afterwards we can work on it more actively. |
Hi,
Yes, I ll address comments this week
15 Apr 2019, 15:05 by notifications@github.com:
…
@redbaron <https://github.com/redbaron>> do you want to continue development of this PR? Could you then address the commentaries, and afterwards we can work on it more actively.
—
You are receiving this because you were mentioned.
Reply to this email directly, > view it on GitHub <#507 (comment)>> , or > mute the thread <https://github.com/notifications/unsubscribe-auth/AABA8B_qxWuYN2vFFo1VUPaqMeKQTaAyks5vhIcigaJpZM4bXdqx>> .
|
f9dd272
to
316e3c9
Compare
316e3c9
to
c0710da
Compare
@erthalion , I've rebased PR and updated manifest with an example, could you have a look please? |
c0710da
to
e4f2f18
Compare
interesting, I'll have a look, thanks!
Sent with [ProtonMail](https://protonmail.com) Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Wednesday, 19 June 2019 14:10, Felix Kunde ***@***.***> wrote:
***@***.***(https://github.com/redbaron) thanks for the update. Actually, we have (sort or) build up on your work in the meantime with [#562](#562) which we plan to merge pretty soon. Please, have a look and tell if it would work for you so we can close this PR here.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#507?email_source=notifications&email_token=AAAEB4BJANXB3AGAFFJ7SWTP3IV4JA5CNFSM4G253KY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYBZ6PQ#issuecomment-503553854), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAAEB4A3K7WPBOBIRNRIJ2LP3IV4JANCNFSM4G253KYQ).
|
@FxKu , there is a very little overlap except for word "standby". This PR utilizes patroni's that one seems to configure standby with WAL shipping from S3 |
@redbaron we also require this feature of standby cluster with streaming replication. When is this PR likely to be merged to the master? |
For information : I've succefully rebased this PR in my workspace and now I can create a standby cluster replicating an existing database (outside of cluster). @redbaron I'd love to see your PR merged. Can re-base it please ? |
# standby_cluster: | ||
# host: master.hostname | ||
# port: "5432" | ||
# primary_slot_name: dmz2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this part behind maximum_lag_on_failover
. Only then it's under the patroni
key. You can remove the black lines and maybe also # standby cluster example.
. I see that some fields from the PatroniStandbyCluster struct are also missing. Are only these three fields required?
We are looking for standby cluster with streaming replication feature, when will this PR be merged? |
I wanted to share my workaround with anyone who is looking for this feature. So all you have to do is:
Logs: You can also scale the standby cluster $ patronictl -c /home/postgres/postgres.yml list
|
@sreenandan |
@FxKu Ping |
Anyone interested please open a new PR. Feel free to reuse code if you find it useful. |
Support for standby cluster mode
xref: #428