Fix patroni config updates #513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stang
requested review from
CyberDem0n,
FxKu,
Jan-M,
alexeyklyukin,
avaczi,
erthalion and
sdudoladov
as code owners
stang
force-pushed
the
fix-patroni-config-updates
branch
2 times, most recently
from
fe4176b to
2452cd5
Compare
golangcibot
reviewed
Mar 6, 2019
Signed-off-by: Stephane Tang <hi@stang.sh>
stang
force-pushed
the
fix-patroni-config-updates
branch
from
2452cd5 to
066c669
Compare
Fixes zalando#501 Signed-off-by: Stephane Tang <hi@stang.sh>
Fixes zalando#447 Signed-off-by: Stephane Tang <hi@stang.sh>
stang
force-pushed
the
fix-patroni-config-updates
branch
from
066c669 to
d4faf3f
Compare
|
@FxKu - sorry I wasn't more active on this. I've just merged-back current |
stang
force-pushed
the
fix-patroni-config-updates
branch
from
9b8f387 to
7f5ca22
Compare
sdudoladov
reviewed
Jun 28, 2019
| // patroni configuration is not always reflected on the StatefulSet as they have | ||
| // different lifecycle (due to SPILO's implementation - see: issues#501) but they | ||
| // still need to be updated via the Patroni REST API. | ||
| if err := c.applyPatroniConfig(); err != nil { |
There was a problem hiding this comment.
is the intention here to update Patroni config in DCS on every Update event even if the actual config did not change ?
| } | ||
| } | ||
|
|
||
| config.Bootstrap.DCS.Slots = oldestKnownPatroniCfg.Slots |
There was a problem hiding this comment.
but at this point the cluster already exists and bootstrap options have no effect. why are we resetting it again ? to get the same stateful set spec ?
sdudoladov
reviewed
Jun 28, 2019
| } | ||
|
|
||
| func generateSpiloJSONConfiguration(pg *acidv1.PostgresqlParam, patroni *acidv1.Patroni, pamRoleName string, logger *logrus.Entry) (string, error) { | ||
| func generateSpiloJSONConfiguration(pg *acidv1.PostgresqlParam, patroni *acidv1.Patroni, pamRoleName string, logger *logrus.Entry, isNewCluster bool, initialPatroniConfig string) (string, error) { |
There was a problem hiding this comment.
tests also need to be updated
pkg/cluster/k8sres_test.go:76:48: not enough arguments in call to generateSpiloJSONConfiguration
have (*"github.com/zalando/postgres-operator/pkg/apis/acid.zalan.do/v1".PostgresqlParam, *"github.com/zala
ndo/postgres-operator/pkg/apis/acid.zalan.do/v1".Patroni, string, *logrus.Entry)
want (*"github.com/zalando/postgres-operator/pkg/apis/acid.zalan.do/v1".PostgresqlParam, *"github.com/zala
ndo/postgres-operator/pkg/apis/acid.zalan.do/v1".Patroni, string, *logrus.Entry, bool, string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing #447 and #501
Note: for the update path, when deploying this new version of
postgres-operator, it will automatically re-apply patroni config that are set in the current cluster spec, without restarting the pods.