Add region setting for logical backups to non-AWS storage

[vitobotta]

Hi! Following the example of #628 I've added a setting for the region when configuring logical backups. With some S3-compatible services like Scaleway you need to specify the region as well as the endpoint in the aws upload command, otherwise the upload fails. I found this while investigating with the dump.sh script and found that I had to add --region <region> to the aws command for the upload to succeed. Tested many times.Hope this is OK. Thanks!

[FxKu]

Thanks for this PR.
This new option is not yet covered by CRD validation. Please add it (in alphabetical order).

I think at some point we should switch to a map to pass all these arguments. Cannot create a new field every time a user needs another s3 cp option.

[vitobotta]

Hi @FxKu ! I've added the missing bit. Hopefully it's OK now. :) I'm still new to this stuff. Thanks

[FxKu]

Validation is still missing. Let me point you to the correct places (insert before the line I've linked):
CRD manifest
Manifest copy for Helm chart
CRD validation in Go code

[vitobotta]

Hi @FxKu is it OK now or is there anything else missing? Thank you for your patience :)

[vitobotta]

Looks like the last commit failed. Something else missing perhaps? Sorry, I'm not familiar with Go etc yet.

[FxKu]

Retriggered the travis build and now it succeeds. Can you update my last suggestions. Sorry missed them before. Then it's done 😃

[vitobotta]

@FxKu Done. Hopefully it's OK this time :D

[FxKu]

👍

[hjacobs]

👍

[hjacobs]

@vitobotta thanks for your blog post!

[vitobotta]

@hjacobs Thank you guys for open sourcing this! :)

[Jan-M]

Just FYI on your blog post: We do intentionally not use wal-g for shipping backups despite the fact that it is significantly fast. We do though use it for restoring.

[vitobotta]

Hi @Jan-M ! I must have missed that that. Are there any problems with using wal-g for backups as well? Do you recommend that I change my clusters because of this?

[vitobotta]

Thanks for merging!