Skip to content

Fixes #708 - Add 'max_connections' function for suggesting a value #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

Fixes #708 - Add 'max_connections' function for suggesting a value #714

merged 2 commits into from
Sep 17, 2025

Conversation

ralf401
Copy link
Contributor

@ralf401 ralf401 commented Sep 17, 2025

No description provided.

@ralf401 ralf401 self-assigned this Sep 17, 2025
@ralf401 ralf401 linked an issue Sep 17, 2025 that may be closed by this pull request
Add rails command for psql max_connections #708
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2025 •
edited
Loading

Artifacts

Produced during runtime

📦 epub-8d2a6d0
📦 html-8d2a6d0
📦 htmlzip-8d2a6d0

@ralf401
Copy link
Contributor Author

ralf401 commented Sep 17, 2025

@mantas & @mgruner: can you please have a look? I skipped adding the environment variables to the separate environment variables page because I think they could be miss-interpreted as if they could limit certain values. As far as I understood, they are just for the calculation of the max_connections, right?

mantas
mantas reviewed Sep 17, 2025
View reviewed changes
mgruner
mgruner reviewed Sep 17, 2025
View reviewed changes
@mgruner
Copy link
Contributor

mgruner commented Sep 17, 2025

@ralf401 looks good in general. I would just simplify this slightly.

@ralf401
Copy link
Contributor Author

ralf401 commented Sep 17, 2025

Thank you both! I changed it according to your suggestions. Please have a final look if I got it right.

@ralf401 ralf401 requested review from mantas and mgruner September 17, 2025 11:39
@mgruner
Copy link
Contributor

mgruner commented Sep 17, 2025

Looks good to me!

Would be nice to have the artifacts regenerated on pushes, not only for the initial PR. Maybe you can create an item for that?

@mgruner
Copy link
Contributor

mgruner commented Sep 17, 2025

Ah, it seems they may even have been regenerated (article updated).

@ralf401
Copy link
Contributor Author

ralf401 commented Sep 17, 2025

Ah, it seems they may even have been regenerated (article updated).

Yes correct, they are always updated. Thanks, I'll merge it then.

@ralf401 ralf401 merged commit 3b3a94c into pre-release Sep 17, 2025
1 check passed
@ralf401 ralf401 deleted the rsc/fixes/708 branch September 17, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantas mantas Awaiting requested review from mantas

@mgruner mgruner Awaiting requested review from mgruner

Assignees

@ralf401 ralf401

Labels
📚documentation📚
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rails command for psql max_connections
3 participants
@ralf401 @mgruner @mantas