Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-arch docker builds including arm64 #4861

Closed
wants to merge 31 commits into from

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Oct 5, 2023

This adds support for multi-arch builds based on self hosted runners.

@mgruner mgruner requested a review from monotek October 5, 2023 11:51
@mgruner
Copy link
Collaborator Author

mgruner commented Oct 5, 2023

@monotek this is not 100% complete, but I would like to ask for your feedback. Do you agree with this approach in general? Any recommendations?

@mgruner mgruner changed the title Develop GitHub docker arm64 Add multi-arch docker builds including arm64 Oct 5, 2023
@monotek
Copy link
Member

monotek commented Oct 5, 2023

I see guithhub artifact upload and donwload for the maifest is used.
Is this faster as before?
If so, i'm fine with it :)

@mgruner
Copy link
Collaborator Author

mgruner commented Oct 5, 2023

@monotek this data transfer is needed because the jobs to push the platform images must run first (as they are on different native platforms). Then the final jobs build the multiarch manifest lists from the generated images.

The whole process takes around 10 minutes, I believe this is pretty good. And we can add more platform jobs in future, in case that should become necessary.

I was able to run zammad-docker-compose from the generated image on arm64 just fine. So if you agree, I would perform final clean-ups and then merge it to production. For existing docker-compose or kubernetes installations nothing should change. 🤞

@monotek
Copy link
Member

monotek commented Oct 6, 2023

Sounds good. Lets do it :)

@mgruner mgruner closed this Oct 6, 2023
@mgruner mgruner deleted the develop-github-docker-arm64 branch October 6, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants