Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to TypeScript 3 #1022

Merged
merged 1 commit into from
Aug 17, 2018
Merged

chore: update to TypeScript 3 #1022

merged 1 commit into from
Aug 17, 2018

Conversation

seanf
Copy link
Contributor

@seanf seanf commented Aug 14, 2018

https://blogs.msdn.microsoft.com/typescript/2018/07/30/announcing-typescript-3-0/

Checklist

  • JIRA link
  • Check target branch
  • Make sure all commit statuses are green or otherwise documented reasons to ignore
  • QA needs to evaluate against the JIRA ticket
  • Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.


This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

@zubot
Copy link
Member

zubot commented Aug 14, 2018

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1022 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1022      +/-   ##
============================================
+ Coverage     36.82%   36.88%   +0.05%     
- Complexity     6128     6177      +49     
============================================
  Files          1649     1649              
  Lines         65356    65638     +282     
  Branches       7615     7649      +34     
============================================
+ Hits          24070    24209     +139     
- Misses        39189    39328     +139     
- Partials       2097     2101       +4
Impacted Files Coverage Δ Complexity Δ
...nata/async/handle/MergeTranslationsTaskHandle.java 93.33% <0%> (-6.67%) 7% <0%> (+2%)
...org/zanata/async/handle/CopyVersionTaskHandle.java 52.38% <0%> (-5.96%) 5% <0%> (+1%)
...nd/src/app/editor/reducers/phrase-reducer/index.js 85.62% <0%> (ø) 0% <0%> (ø) ⬇️
...c/main/java/org/zanata/action/DashboardAction.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...end/src/app/editor/reducers/suggestions-reducer.js 100% <0%> (ø) 0% <0%> (ø) ⬇️
...r/reducers/phrase-reducer/filter-status-reducer.js 100% <0%> (ø) 0% <0%> (ø) ⬇️
.../main/java/org/zanata/action/CopyTransManager.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ontend/src/app/editor/reducers/settings-reducer.js 80.45% <0%> (ø) 0% <0%> (ø) ⬇️
...ain/java/org/zanata/action/CopyVersionManager.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...rc/main/java/org/zanata/async/AsyncTaskHandle.java 65.76% <0%> (+0.05%) 59% <0%> (+19%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68a384...73ab386. Read the comment docs.

@seanf seanf changed the title Update to TypeScript 3 chore: update to TypeScript 3 Aug 17, 2018
@djansen-redhat djansen-redhat added Reviewed On QA djansen Damian has taken this for testing Verified and removed On QA djansen Damian has taken this for testing labels Aug 17, 2018
@djansen-redhat
Copy link
Contributor

Verified, but only to a cursory level

@seanf seanf merged commit 5ad4e23 into master Aug 17, 2018
@seanf seanf deleted the typescript-3 branch August 17, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants