Reports: Add traditional JSON report #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
May 27, 2021
psiinon
force-pushed
the
reports/json-template
branch
2 times, most recently
from
a33911e
to
a0e2a92
Compare
|
Now refactored and ready for review. The JSON reports should be equivalent to the existing core ones with the I'll need to make similar changes to the XML report. |
kingthorin
reviewed
Jun 1, 2021
addOns/reports/src/main/java/org/zaproxy/addon/reports/ReportHelper.java
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
reports/json-template
branch
from
a0e2a92
to
e52146e
Compare
kingthorin
approved these changes
Jun 2, 2021
The JSON reports should be equivalent to the existing core ones with the exception of the formating. The escaping should be exactly the same. The aim is to ensure anyone who relies on these reports should not be impacted when we switch over. I'll need to make similar changes to the XML report. Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
reports/json-template
branch
from
e52146e
to
ed6480d
Compare
thc202
approved these changes
Jun 2, 2021
|
Thank you! |
This was referenced Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2951 - will refactor this once thats merged.