util: create os-specific layer for syscalls #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using some syscalls directly to handle STDOUT and STDERR redirects. These calls were done for Linux specific systems, which don't work for Windows. That's not the first time we hit such issue. With that, this patch creates compatibility files dedicated to Windows and any other Unix-like systems. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 57.48% 57.54% +0.05%
==========================================
Files 67 68 +1
Lines 4347 4350 +3
==========================================
+ Hits 2499 2503 +4
Misses 1605 1605
+ Partials 243 242 -1
Continue to review full report at Codecov.
|
prarit
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OS-specific files for handling syscalls.
This file should be used as a compatibility layer.
Fixes #598
NOTE: this MR is required to allow our next release.