util: fix dup2() usage for Linux and Darwin #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must create a new Darwin specific file to handle the lack of DUP2() in Linux ARM64 systems and also the lack of DUP3() in Darwin. In other words: Linux ARM64 must use DUP3() while Darwin must use DUP2(). Other BSDs have DUP3(), allowing us to use the same Linux file for them. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
prarit
approved these changes
Feb 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 57.54% 57.54%
=======================================
Files 68 68
Lines 4350 4350
=======================================
Hits 2503 2503
Misses 1605 1605
Partials 242 242
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And we have yet another OS-specific issue to solve.
This time is a diff between Linux and Darwin (MacOS):
Down side of that is: great part of _unix.go file must be replicated in _darwin.go one.
For the sake of getting a new release out of the door, I'm literally copying+pasting the code, but it should (I HOPE) have a better way to handle this "partial" incompatibility.
EDIT: dup3() is available from userspace in Linux ARM64 glibc, but we don't have access to it from Go lib and we can't rely every system uses glibc.