Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show spellcheck correction suggestions in right-click #46

Closed
zarino opened this issue Aug 4, 2015 · 0 comments · Fixed by #50
Closed

Show spellcheck correction suggestions in right-click #46

zarino opened this issue Aug 4, 2015 · 0 comments · Fixed by #50
Labels
code epic

Comments

@zarino
Copy link
Owner

zarino commented Aug 4, 2015

75df6f7 added native spellchecking for the message composition box. However, when you right-click underlined words, nothing happens.

Here's the menu I get when I right-click a misspelt word in a standard Chrome textarea:

screen shot 2015-08-04 at 07 38 01

The absolute minimum to satisfy this ticket would just have a right-click menu containing the spelling suggestions.

But to make it feel like a real Mac app (see #47), I'd also expect Cut/Copy/Paste/Delete, Select All, maybe even Look Up in Dictionary.
@zarino zarino mentioned this issue Aug 4, 2015
Closed
zarino added a commit that referenced this issue Aug 6, 2015
@zarino
Abstract various menus into multi-purpose NativeMenu class
1a79d31 
The new module NativeMenu can be used to create an application menu
(at the top of the screen on a Mac) or a context menu (like those
shown on right-click). It has a .construct() method that allows you
to completely replace its contents at any time, which means the
same NativeMenu instance can be re-used for a number of purposes,
with the contents being replaced on-demand to suit the situation.

NativeMenu is now used for the main application menu, and the
channelButtonView right-click menu. It will also, soon, be used
in the spelling suggestion right-click menu (#46) and the standard
text selection right-click menu (#47).
zarino added a commit that referenced this issue Aug 6, 2015
@zarino
Abstract various menus into multi-purpose NativeMenu class
890dd52 
The new module NativeMenu can be used to create an application menu
(at the top of the screen on a Mac) or a context menu (like those
shown on right-click). It has a .construct() method that allows you
to completely replace its contents at any time, which means the
same NativeMenu instance can be re-used for a number of purposes,
with the contents being replaced on-demand to suit the situation.

NativeMenu is now used for the main application menu, and the
channelButtonView right-click menu. It will also, soon, be used
in the spelling suggestion right-click menu (#46) and the standard
text selection right-click menu (#47).
@zarino zarino mentioned this issue Aug 6, 2015
Merged
zarino added a commit that referenced this issue Aug 6, 2015
@zarino
Show spelling suggestions and text editing options in context menu
de8884c 
Fixes #46.
@zarino zarino mentioned this issue Aug 6, 2015
Merged
@zarino zarino closed this as completed in #50 Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Text context menus on right-click zarino/backchat
1 participant
@zarino