Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Mac-standard right-click menu for text in scrollback #47

Closed
zarino opened this issue Aug 4, 2015 · 0 comments · Fixed by #50
Closed

Show Mac-standard right-click menu for text in scrollback #47

zarino opened this issue Aug 4, 2015 · 0 comments · Fixed by #50
Labels
code epic

Comments

@zarino
Copy link
Owner

zarino commented Aug 4, 2015

Building on #46, I'd expect to be able to, at the very least, copy selected text in the scrollback. Maybe also Look Up in Dictionary.
@zarino zarino mentioned this issue Aug 5, 2015
Closed
zarino added a commit that referenced this issue Aug 6, 2015
@zarino
Abstract various menus into multi-purpose NativeMenu class
1a79d31 
The new module NativeMenu can be used to create an application menu
(at the top of the screen on a Mac) or a context menu (like those
shown on right-click). It has a .construct() method that allows you
to completely replace its contents at any time, which means the
same NativeMenu instance can be re-used for a number of purposes,
with the contents being replaced on-demand to suit the situation.

NativeMenu is now used for the main application menu, and the
channelButtonView right-click menu. It will also, soon, be used
in the spelling suggestion right-click menu (#46) and the standard
text selection right-click menu (#47).
zarino added a commit that referenced this issue Aug 6, 2015
@zarino
Abstract various menus into multi-purpose NativeMenu class
890dd52 
The new module NativeMenu can be used to create an application menu
(at the top of the screen on a Mac) or a context menu (like those
shown on right-click). It has a .construct() method that allows you
to completely replace its contents at any time, which means the
same NativeMenu instance can be re-used for a number of purposes,
with the contents being replaced on-demand to suit the situation.

NativeMenu is now used for the main application menu, and the
channelButtonView right-click menu. It will also, soon, be used
in the spelling suggestion right-click menu (#46) and the standard
text selection right-click menu (#47).
@zarino zarino mentioned this issue Aug 6, 2015
Merged
zarino added a commit that referenced this issue Aug 6, 2015
@zarino
Allow right click on scrollback to show standard text context menu
e875bb1 
Fixes #47.
@zarino zarino mentioned this issue Aug 6, 2015
Merged
@zarino zarino closed this as completed in #50 Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Text context menus on right-click zarino/backchat
1 participant
@zarino