Skip to content

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 9, 2025

This PR replaces the crc32c dependency with the google-crc32c package. The behavior of the codec is not expected to have changed.

Closes zarr-developers/zarr-python#3510

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (b543298) to head (61d7e14).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   90.33%   90.37%   +0.04%     
==========================================
  Files          64       64              
  Lines        2804     2817      +13     
==========================================
+ Hits         2533     2546      +13     
  Misses        271      271              
Files with missing lines Coverage Δ
numcodecs/checksum32.py 100.00% <100.00%> (ø)
numcodecs/tests/test_checksum32.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhamman
Copy link
Member Author

jhamman commented Oct 9, 2025

The failing tests here are due to a nasty circular dependency in our test suite with respect to zarr-python. I don't believe there is anything that can be done about that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop numcodecs[crc32c] as dependency due to use of LGPL license
1 participant