Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy all turtle files in the docker image #1543

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

giacomociti
Copy link
Contributor

let's discuss here also with @ludovicm67 if we want a more pervasive replacement of ADD with COPY

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 3e896af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-creator/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (fb060a7) to head (3e896af).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1543   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         220      220           
  Lines       14945    14945           
  Branches      849      849           
=======================================
  Hits        10997    10997           
  Misses       3939     3939           
  Partials        9        9           
Flag Coverage Δ
73.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giacomociti I think that all the ADD could be replaced with COPY without any issue :)

Co-authored-by: Tomasz Pluskiewicz <tpluscode@users.noreply.github.com>
@giacomociti giacomociti merged commit 5e6e9a6 into master Oct 1, 2024
23 checks passed
@giacomociti giacomociti deleted the fix-dockerfile branch October 1, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants