Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Prefix Labels #73

Closed
nnamtug opened this issue Feb 14, 2020 · 2 comments
Closed

Unify Prefix Labels #73

nnamtug opened this issue Feb 14, 2020 · 2 comments
Assignees

Comments

@nnamtug
Copy link
Collaborator

nnamtug commented Feb 14, 2020

https://github.com/zazuko/rdf-mapping-dsl/blob/bda63d6d3eb6e42164ad09f69b00973311679a9f/runtime-EclipseXtext/airport-mapping/vocabularies.xrm#L2

Separating character ':' is used in the payload of Prefix.label in DSL-Files. This looks suspicous, since a separating character should be part of the tooling, not of the payload. For example see #34 , there only pure payload is meant to put in label. I propose to validate not having separators in the payload and implement them in the generators.

Implies changes in existing DSL files.

@mchlrch please check.

@nnamtug nnamtug changed the title Unify Prefix labels Unify Prefix Labels Feb 14, 2020
@mchlrch
Copy link
Member

mchlrch commented Feb 27, 2020

Yes, this needs harmonization. Prefix declarations should be uniform inside the DSL. Thanks for pointing this out.

only pure payload is meant to put in label.
I propose to validate not having separators in the payload and implement them in the generators.

Yes, let's change this as you propose.

Implies changes in existing DSL files.

That's fine. Validations will mark the places where changes are needed. Providing a quickfix would be nice, also for people that are used to turtle and maybe copy/paste prefix definitions from turtle files.

nnamtug added a commit that referenced this issue Feb 28, 2020
nnamtug added a commit that referenced this issue Feb 28, 2020
@nnamtug nnamtug self-assigned this Feb 28, 2020
@mchlrch
Copy link
Member

mchlrch commented Mar 5, 2020

Tested and works. Nice that it comes with quickfix included

@nnamtug nnamtug closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants