Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the check that Merkle roots are not ⊥ for Orchard #530

Closed
wants to merge 5 commits into from
Closed

Remove the check that Merkle roots are not ⊥ for Orchard #530

wants to merge 5 commits into from

Commits on Jun 30, 2021

  1. Delete the consensus rule in \crossref{transactions} that required ch… 

    …ecking that each intermediate

Merkle root of the note commitment tree is not ⊥. Checking this rule would have imposed a
significant performance penalty, since intermediate roots do not otherwise need to be computed.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
    @daira
    daira committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    717a46b View commit details
    Browse the repository at this point in the history

  2. Change the type of MerkleCRH^Orchard to have MerkleHash^Orchard in pl… 

    …ace of MerkleHash^Orchard ∪ {⊥}

for the inputs and output, and map a ⊥ output from SinsemillaHash to 0.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
    @daira
    daira committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    05ba3a1 View commit details
    Browse the repository at this point in the history

  3. Allow the Merkle path validity check in the Action circuit to pass if… 

    … any output of

MerkleCRH^Orchard is 0, and add a note in \crossref{merklepath} arguing that this is safe.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
    @daira
    daira committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    ce1529d View commit details
    Browse the repository at this point in the history

  4. Fix a typo in the Security Requirements for \crossref{orchardmerklecr… 

    …h}: the length of the input

to SinsemillaHash is 10 + 2·ℓ^Orchard_Merkle bits, not 6 + 2·ℓ^Orchard_Merkle bits.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
    @daira
    daira committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    1ce9739 View commit details
    Browse the repository at this point in the history

  5. Regenerate protocol.pdf. 

    Signed-off-by: Daira Hopwood <daira@jacaranda.org>
    @daira
    daira committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    cc3b523 View commit details
    Browse the repository at this point in the history