-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIP 320: choose TEX Address alternative #798
Conversation
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One blocking comment, plus suggestions.
In order to show accurate transaction history to a user, wallets SHOULD | ||
remember when a particular transaction output was sent to a TEX Address, so | ||
that they can show that form rather than its P2PKH form. It is acceptable that | ||
this information may be lost on recovery from seed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the place for it, but a standard for how to format a (potentially-zero-valued) internal shielded change memo in the deshielding transaction could help mitigate this toe-stub potential.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
34be45e
to
e5a24b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e5a24b4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A non-blocking comment would be to remove the UA alternative context from the Rationale section into its own section. It kind of comes out of the blue when I read through the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it's too short now to justify another section. |
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
fixes #795