fix: Don't error if $OPTS is not yet defined in .zinit-compinit call

[jankatins]

This codepath was triggered when deleting the whole ~/.ziniti/plugins dir: during recreation in .zinit-prepare-home, .zinit-compinit &> /dev/null would be called and the sourcing of zinit.zsh would error out with

+.zinit-compinit:2> [[.zinit-compinit:2: bad math expression: operand expected at `/Users/jan...'
 -n '' ]]

As the error was redirected to /dev/null, this never showed up. Any zinit install call during that session would not run any hooks as they were not yet registered. The next session would then be fine because the plugins dir would exist.

Motivation and Context

See #129 (comment) -> basically deleting the ~/.zinit/plugins dir should result in complete recreation on the next run, but due to this bug, it had bad side effects.

Closes: #129 (probably, not tested on initial run, only after deleting the plugins dir)

How Has This Been Tested?

Manually deleting the whole folder and starting the whole zinit setup from scratch

rm -rf ~/.zinit/plugins/ && exec zsh

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[vladdoster]

@jankatins Awesome find and fix. I really appreciate the use of commit message using the prefix fix:!

[vladdoster]

@pschmitt @jankatins The conditional should have used -v

[[ -v SOME_VARIABLE ]]

[pschmitt]

Pendantic but true, this is effectively the same though.

[vladdoster]

Since it errors on operand and would result in smaller diff, is there a reason not to use

(( expr ))

I see

[[ expr ]]

used elsewhere, but seems redundant to check the same variable twice.

@jankatins @pschmitt

[vladdoster]

Regardless of the answer above, this brings up the issue of deleting zinit directories.

As I've said before @jankatins, this is not how you should delete plugins.

Use zinit delete --all

I would assume this edge-case is handled in the delete command since it deletes subdirectories and not the actual $ZINIT[PLUGINS_DIR] directory. So, is this needed or just not using the proper method of deleting plugins?

[pschmitt]

zsh man page :

In other words,
[[ $var ]] is the same as [[ -n $var ]]. It is
recommended that the second, explicit, form be used where
possible.

[vladdoster]

Regardless of the answer above, this brings up the issue of deleting zinit directories.

As I've said before @jankatins, this is not how you should delete plugins.

Use zinit delete --all

I would assume this edge-case is handled in the delete command since it deletes subdirectories and not the actual $ZINIT[PLUGINS_DIR] directory. So, is this needed or just not using the proper method of deleting plugins?

Link to my previous comment

[vladdoster]

zsh man page :

In other words,
[[ $var ]] is the same as [[ -n $var ]]. It is
recommended that the second, explicit, form be used where
possible.

TIL :^)

[vladdoster]

Regardless of the answer above, this brings up the issue of deleting zinit directories.
As I've said before @jankatins, this is not how you should delete plugins.

Use zinit delete --all
I would assume this edge-case is handled in the delete command since it deletes subdirectories and not the actual $ZINIT[PLUGINS_DIR] directory. So, is this needed or just not using the proper method of deleting plugins?

Link to my previous comment

Indeed, it avoids this issue altogether.

[github-actions]

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀