Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gleam icon #19887

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add Gleam icon #19887

merged 3 commits into from
Oct 29, 2024

Conversation

okkdev
Copy link
Contributor

@okkdev okkdev commented Oct 29, 2024

I took a shot at creating an icon version of the Gleam logo in response to #19529

Release Notes:

  • Added an icon for Gleam files.

image

Screenshot 2024-10-29 at 9 46 33 AM

Copy link

cla-bot bot commented Oct 29, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @okkdev on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@okkdev
Copy link
Contributor Author

okkdev commented Oct 29, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 29, 2024
Copy link

cla-bot bot commented Oct 29, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!!

Would be great to get this on the Gleam website too https://gleam.run/branding/

@maxdeviant maxdeviant self-assigned this Oct 29, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This should do nicely 😄

@maxdeviant maxdeviant merged commit 9739da8 into zed-industries:main Oct 29, 2024
9 checks passed
@maxdeviant
Copy link
Member

@notpeter Since you're our active Release Tsar, could we get this cherry-picked to Preview?

notpeter pushed a commit that referenced this pull request Oct 29, 2024
I took a shot at creating an icon version of the Gleam logo in response
to #19529

Release Notes:

- Added an icon for Gleam files.


![image](https://github.com/user-attachments/assets/97432ded-342f-4d87-8eb2-dc9145513d8c)

<img width="231" alt="Screenshot 2024-10-29 at 9 46 33 AM"
src="https://github.com/user-attachments/assets/c957c98f-3da0-4b92-bc21-2a5adca1daa3">

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
@okkdev okkdev mentioned this pull request Oct 30, 2024
maxdeviant pushed a commit that referenced this pull request Oct 30, 2024
Improves upon: #19887

Implements the feedback by @PixelJanitor to make the icon follow the
design guidelines.

Release Notes:

- Improved Gleam icon
CharlesChen0823 pushed a commit to CharlesChen0823/zed that referenced this pull request Nov 18, 2024
I took a shot at creating an icon version of the Gleam logo in response
to zed-industries#19529

Release Notes:

- Added an icon for Gleam files.


![image](https://github.com/user-attachments/assets/97432ded-342f-4d87-8eb2-dc9145513d8c)

<img width="231" alt="Screenshot 2024-10-29 at 9 46 33 AM"
src="https://github.com/user-attachments/assets/c957c98f-3da0-4b92-bc21-2a5adca1daa3">

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
CharlesChen0823 pushed a commit to CharlesChen0823/zed that referenced this pull request Nov 18, 2024
Improves upon: zed-industries#19887

Implements the feedback by @PixelJanitor to make the icon follow the
design guidelines.

Release Notes:

- Improved Gleam icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants