Add Gleam icon #19887
Merged
Add Gleam icon #19887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @okkdev on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
lpil
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Fantastic!!
Would be great to get this on the Gleam website too https://gleam.run/branding/
maxdeviant
approved these changes
Oct 29, 2024
|
@notpeter Since you're our active Release Tsar, could we get this cherry-picked to Preview? |
notpeter
pushed a commit
that referenced
this pull request
Oct 29, 2024
I took a shot at creating an icon version of the Gleam logo in response to #19529 Release Notes: - Added an icon for Gleam files.  <img width="231" alt="Screenshot 2024-10-29 at 9 46 33 AM" src="https://github.com/user-attachments/assets/c957c98f-3da0-4b92-bc21-2a5adca1daa3"> --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Merged
maxdeviant
pushed a commit
that referenced
this pull request
Oct 30, 2024
Improves upon: #19887 Implements the feedback by @PixelJanitor to make the icon follow the design guidelines. Release Notes: - Improved Gleam icon
CharlesChen0823
pushed a commit
to CharlesChen0823/zed
that referenced
this pull request
Nov 18, 2024
I took a shot at creating an icon version of the Gleam logo in response to zed-industries#19529 Release Notes: - Added an icon for Gleam files.  <img width="231" alt="Screenshot 2024-10-29 at 9 46 33 AM" src="https://github.com/user-attachments/assets/c957c98f-3da0-4b92-bc21-2a5adca1daa3"> --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
CharlesChen0823
pushed a commit
to CharlesChen0823/zed
that referenced
this pull request
Nov 18, 2024
Improves upon: zed-industries#19887 Implements the feedback by @PixelJanitor to make the icon follow the design guidelines. Release Notes: - Improved Gleam icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a shot at creating an icon version of the Gleam logo in response to #19529
Release Notes: