settings: Include null in the type for optional settings
#20192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
null for optional settingsnull in the type for optional settings
CharlesChen0823
pushed a commit
to CharlesChen0823/zed
that referenced
this pull request
Nov 18, 2024
…tries#20192) This PR updates all settings that are defined as `Option`s to include `null` in their type. This prevents warnings from being displayed when `null` is used a default value. Closes zed-industries#18006. Release Notes: - Updated the settings schema to allow `null` as a value for optional settings instead of showing a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all settings that are defined as
Options to includenullin their type.This prevents warnings from being displayed when
nullis used a default value.Closes #18006.
Release Notes:
nullas a value for optional settings instead of showing a warning.