language servers: Fix wrong language server name #20428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue of multiple language servers showing up as `node` in the language server logs dropdown. It's still WIP because we need to figure out how this works when doing remoting, because that doesn't seem to work well. Co-authored-by: Sam Rose <hello@samwho.dev>
cla-bot
bot
added
the
cla-signed
Co-authored-by: Bennet <bennet@zed.dev>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of multiple language servers showing up as
nodein the language server logs dropdown.It does this by changing
language_server.name()to return the adapter's name, not the binary name, and changing types to make sure that we always use this.Release Notes:
"node"